Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.10 #6891

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Add support for python 3.10 #6891

merged 5 commits into from
Feb 28, 2022

Conversation

AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Feb 23, 2022 •
edited
Loading

Fixes #6795

Testing done:

  • Install only python 3.10, uninstall all other python versions
  • Verify "python version 0.0" gold bar is no longer shown
  • Verify profiling (Debug -> Launch Python Profiling) works for a simple python console application. See comments in PR for code used and screenshot of profiler.
  • Repeat steps above with only python 3.9 installed to make sure we didn't break anything.
  • Have CTI team run through all test scenarios (especially profiling and mixed mode debugging) with both 3.9 and 3.10 once we have a Visual Studio PR for them to test. (This has to happen after THIS PR is merged, but before the VS PR is merged)

@microsoft microsoft deleted a comment from sonarqubecloud bot Feb 23, 2022
@AdamYoblick
Copy link
Member Author

Code used to test profiling on python 3.10 was:

class ConsolePrinter:

    def PrintStrXTimes(self, str, num:int):
        for i in range(num):
            print(str)

def main():

    cp = ConsolePrinter()
    cp.PrintStrXTimes("Hello World!", 5)

if __name__ == "__main__":
    main()

And here's the profiling window showing the results:

image

@AdamYoblick AdamYoblick marked this pull request as ready for review February 23, 2022 23:48
@AdamYoblick AdamYoblick requested a review from a team as a code owner February 23, 2022 23:48
@AdamYoblick AdamYoblick requested a review from zooba February 23, 2022 23:48
@AdamYoblick
Copy link
Member Author

Same code as previous comment used for profiling using Python 3.9. Didn't see any problems:

image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AdamYoblick
Copy link
Member Author

Going to merge this in and have CTI test the insertion PR, will try to fix the failing tests in parallel with CTI testing.

@AdamYoblick AdamYoblick merged commit a1b7802 into main Feb 28, 2022
@AdamYoblick AdamYoblick deleted the fix_python_310 branch February 28, 2022 19:54
@cwebster-99 cwebster-99 mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int19h int19h int19h approved these changes

@zooba zooba Awaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AdamYoblick @int19h